Am when I attempt to make a in app purchase it’s telling me my card is about to expire but it doesn’t expire until 2025

This appears to be a common problem that many folks are experiencing. Apple is aware, but hasn't been able to resolve the issue.

Some folks report that they have added a second payment method, such as PayPal or a different credit card. That allows them to remove the problem credit card. They have then been able to add the card they removed back into their account details and there appear to be no more issues with that card.

M1 Mac mini, macOS 14.2;  Watch, series 7 GPS/cellular, watchOS 10.2; iPad Pro 2nd Gen, iPadOS 16.7.3; iPhone 12 Pro, iOS 17.2; TV 4th Gen, tvOS 17.2; HomePods, audioOS 17.2 and Airport Express w/ Airplay 2