I can sign in my icloud using browser but icloud for windows will not allow me to sign in.

Greetings YCEK,

Are you using security software on your PC? If so, that may be preventing your Apple ID from being able to sign in to iCloud for Windows.

Check out out the information in the article below:

Resolve issues between iCloud for Windows or iTunes and third-party security software - Apple Support

"If your security software is causing an issue with iCloud for Windows

• You can't sign in with your Apple ID.
• You see "Verification Failed: An unknown error occurred" or "An error occurred during authentication. Please try again." 
• You see "Your setup couldn't start because your username or password is incorrect" or "Your setup couldn't be started because the iCloud server stopped responding."
• iCloud services won't update."

Prior to adjusting security settings, check out the recommended troubleshooting steps from the bottom of the article:

"Before you change your security software's setup: 

• Make sure that the date, time, and time zone are set correctly on your computer. Learn how to update these settings on a Mac or on a PC. 
• Log in to an administrative user account, not a guest account. Learn how to do this on a PC. 
• Update to the latest version of iCloud for Windows or update to the latest version of iTunes.
• Make sure that you have the latest software on your Mac or on your PC.
• Make sure that you set up Windows Hello. Learn how to set it up. 
• Make sure that you only have one type of security software installed. If you have more than one type of security software installed, you might experience performance issues."

If the issue persists, let us know the behavior being experienced when attempting to sign in with your Apple ID, including any error message that is received.

Kind regards.