Why do I lose my Apple Music when I change credit cards

If you change before your subscription Expires there should be no problem:

Change, add, or remove Apple ID payment methods - Apple Support

However, there is no guarantee if or for how long your music library will be retained after the last billing cycle if you cancel your subscription or let it expire.