Photos not synching to iCloud

I'm signed-in on my macbook pro, have imported photos into my library and created a new album, but when I go to any other device of iCloud I can't see the photos or the album created. have tried toggling the options in setting etc, but no luck. In the library the status does say 'updating' but no photos are showing, and it's been running for a while - I can't imaging it wouldn't show photos already updated. Lots of free space on iCloud and network connected (the two common problems I can find)