Giving my iPad to another - deleted iPad from “find my…” app. They still can’t get in say I need to put my Apple ID info in. Should I??

Use the following instructions from How to remove Activation Lock - Apple Support

Unlock on the web

To remove Activation Lock from a device that's not in your possession, follow the steps below. If you purchased a device that's protected by Activation Lock, ask the previous owner to follow these steps. 

1. From a web browser, sign in to iCloud.com with your Apple ID.
2. Go to Find iPhone.
3. Click All Devices at the top of the screen.
4. Select the device that you want to remove from iCloud.
5. Click Erase [device]. Select Next until the device is erased. 
6. Click Remove from Account.

To begin the setup process, restart the device.

What to do before you sell, give away, or trade in your iPhone, iPad, or iPod touch - Apple Support

Refer to the above document for a list of things you should do to prepare to give the iPad to another user. It includes information about removing any personal features. This includes things you can do remotely if you forgot to do them before giving away the device.