Trade in multiple devices

—I was curious in trading in my old iPad, my old iphone and getting an upgrade on my iPad, MacBook and maybe my phone;

I suggest you start here to see if your older devices have any trade-in value:

Apple Trade In - Apple

Not all can be traded.

—would I need to make an appointment to the nearest Apple Store?

As this is the busiest time of year at most retail stores, an appointment is a very good idea, especially if you have to drive a long way to get to an Apple Store.

Please note there are two kinds of appointments: Genius Bar and Shopping Help.

You need to make an appointment for the latter. Find the store you wish to visit. Example for Apple's Spokane WA Store:

River Park Square - Apple Store - Apple

The "Shop by Appointment" link is at the top of the page and should let you book online: