Will I lose any data or photos if I switch my Apple ID to a new email?
I no longer have access to my email that is associated with my Apple ID. Will I lose any data or photos if I switch my Apple ID to a new email?
iPhone 8 Plus
You should keep all your data, photos, and purchases.
Note the restrictions in the article.
What to do after you change your Apple ID or password - Apple Support I suggest doing this before you change your Apple ID or password.