sharing iphoto photos

We have eight devices; 2 iphones, 2 ipads, 2 Apple watches, and 2 mac desktops. We have family sharing set up for icloud so that all of our photos will download to all of our devices. It no longer works; I’ve checked all of the settings I can think of. Can anyone help?

[Re-Titled by Moderator]

Original Title: sharing iphoto photos