iCloud sharing
my daughter shares my Apple ID, how do I separate our photos on the cloud, so i don't get her photos and she doesn't get mine?
Have her get and use her own Apple ID. Sharing Apple IDs has become more and more problematic as more and more services are using iCloud. All devices with the same Apple ID for iCloud which have iCloud Photos turned on will have their photos synced.
You can each have your own ID and still share selected things via Family Sharing. See: Family Sharing - Apple Support